Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External Redirect のアラートフィルタを追加 #585

Merged
merged 1 commit into from
Oct 12, 2022
Merged

External Redirect のアラートフィルタを追加 #585

merged 1 commit into from
Oct 12, 2022

Conversation

nanasess
Copy link
Contributor

@nanasess nanasess commented Sep 7, 2022

ペネトレーションテストにおいて、External Redirect の脆弱性が検知されている
https://github.com/EC-CUBE/ec-cube2/runs/8191563009?check_suite_focus=true#step:9:64

該当のレスポンスを確認すると、以下のようになっており外部リダイレクトは発生しない

HTTP/1.1 302 Found
Date: Wed, 07 Sep 2022 08:13:06 GMT
Server: Apache/2.4.38 (Debian)
Set-Cookie: legacy-ECSESSID=75a211e559e7852ec5975f15c4955733; path=/; secure; HttpOnly
X-XSS-Protection: 1; mode=block
X-Content-Type-Options: nosniff
X-Frame-Options: DENY
Location: https://ec-cube/cart/index.php?category_id=925909478295518625.owasp.org&transactionid=037dec63ac10f7a5e9aabee7323b0f923a6f14fc
Content-Length: 0
Keep-Alive: timeout=5, max=100
Connection: Keep-Alive
Content-Type: text/html; charset=UTF-8

誤検知のため、アラートフィルタを追加する

@chihiro-adachi chihiro-adachi added this to the 2.17.3 milestone Oct 12, 2022
@chihiro-adachi chihiro-adachi merged commit 0cd6944 into EC-CUBE:master Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nobuhiko nobuhiko nobuhiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.18(仮)
Development

Successfully merging this pull request may close these issues.
3 participants
@nanasess @nobuhiko @chihiro-adachi